Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revives "Stops Queen from stomping on Xenos with relevant pass flags (Lessers/Huggers/Larva) " #7228

Merged
merged 2 commits into from
Oct 5, 2024

Conversation

Venuska1117
Copy link
Contributor

@Venuska1117 Venuska1117 commented Sep 27, 2024

About the pull request

Revives the best PR ever made: #6618

It was closed because of GrrrKitten inactivity.

Explain why it's good for the game

Getting stomp by queen when you do your task as lesser/facehugger/larva can be frustrating, it removes inconvinience.

Testing Photographs and Procedure

Screenshots & Videos

Put screenshots and videos here with an empty line between the screenshots and the <details> tags.

Changelog

🆑 GrrrKitten
qol: Stops Queen from stomping on xenos with relevant pass flags (Larva, Hugger, Lesser)
/:cl:

@cmss13-ci cmss13-ci bot added the Quality of Life Make the game harder to play label Sep 27, 2024
Copy link
Member

@harryob harryob left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this pr has exactly the same issue w binary operators from the original pr

@Venuska1117 Venuska1117 changed the title Revive "Stops Queen from stomping on Xenos with relevant pass flags (Lessers/Huggers/Larva) " Revives "Stops Queen from stomping on Xenos with relevant pass flags (Lessers/Huggers/Larva) " Sep 28, 2024
@harryob harryob added this pull request to the merge queue Oct 5, 2024
Merged via the queue into cmss13-devs:master with commit 42d5958 Oct 5, 2024
28 checks passed
cmss13-ci bot added a commit that referenced this pull request Oct 5, 2024
harryob pushed a commit that referenced this pull request Oct 5, 2024
# About the pull request

Queen was unable to stomp *any* other xeno after
#7228

We want to OR the two conditions first, and then AND them. Currently we
were AND'ing the first 2 parameters (giving 0 in most cases), and then
OR'ing them. (giving non-zero)

Adds a continue instead of a return in the case that we have multiple
xenos on the tile, some of which we want to stomp

Fixed now.

# Explain why it's good for the game
# Testing Photographs and Procedure
<details>
<summary>Screenshots & Videos</summary>

Put screenshots and videos here with an empty line between the
screenshots and the `<details>` tags.

</details>


# Changelog
:cl:
fix: Fixes being unable to stomp xenos as Queen
/:cl:
@Venuska1117 Venuska1117 deleted the revive-better-queen-stomp branch October 19, 2024 20:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Quality of Life Make the game harder to play
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants